Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link-Checker-API not working inside Collections Publisher #174

Closed
ChrisBAshton opened this issue Aug 21, 2019 · 2 comments
Closed

Link-Checker-API not working inside Collections Publisher #174

ChrisBAshton opened this issue Aug 21, 2019 · 2 comments

Comments

@ChrisBAshton
Copy link
Contributor

ChrisBAshton commented Aug 21, 2019

image

Inside collections-publisher:

govuk-docker startup e2e

Then navigate to http://collections-publisher.dev.gov.uk/step-by-step-pages and create or view a step by step and then click "Check for broken links"; we get a 503 error.

This happens even if you run govuk-docker startup inside link-checker-api in another tab. As of alphagov/link-checker-api#284, you can now have link-checker-api running in another tab and this is available to collections-publisher, fixing the issue. But we shouldn't have to do this - the e2e stack should account for the link-checker-api dependency and resolve it automatically.

@benthorner
Copy link
Contributor

@ChrisBAshton I've tried this myself and it seems to work OK now, without any extra steps. I did have to pull the latest versions of the two repos in question.

Screen Shot 2019-11-11 at 15 18 40

@ChrisBAshton
Copy link
Contributor Author

Thanks Ben. Yes I think this issue crops up now and again and required an image rebuild of the repos in question. Think I updated the govuk-docker readme to that effect, but forgot to close this issue. Closing now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants