Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mongo-2.6 for router & router-api #499

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

barrucadu
Copy link
Contributor

The route reloading mechanism in router relies on the output format of
rs.status(), which is different in 3.6. Since we're using mongo 2.x
in production, downgrade the version used for router.

@benthorner
Copy link
Contributor

Ooh, will this fix alphagov/router#210?

@barrucadu
Copy link
Contributor Author

Yes, with this branch I get 103 passed, 0 failed, 2 pending, 1 skipped from make test

projects/router/Makefile Outdated Show resolved Hide resolved
The route reloading mechanism in router relies on the output format of
`rs.status()`, which is different in 3.6.  Since we're using mongo 2.x
in production, downgrade the version used for router.
Copy link
Contributor

@karlbaker02 karlbaker02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for this Michael 💯

@barrucadu barrucadu merged commit dfae503 into main Jun 9, 2021
@barrucadu barrucadu deleted the msw/mongo-router branch June 9, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants