-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded dependencies from Dockerfiles #507
Conversation
@kevindew This doesn't have to be pulled in, but as far as I can tell through looking, Chromium just doesn't need these anymore, nor does it affect our environment. |
@Tetrino I wasn't able to test this by running But what I did do was check out the |
@ChrisBAshton It is possible they returned the dependencies to the repo, or updated them. I will need to find extra time to test them when possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @Tetrino for digging into this, apologies I didn't notice this earlier
I too had the problem that docker builder prune
didn't work, as that only removed dangling images. I think docker image prune -a
will do the trick (but does nuke everything be warned).
Have you tested some projects can still run Chrome ok? I gave this ago myself and I'm pretty confident it works. I was able to run some JS Content Publisher feature tests (I did hit a different annoying issue in Content Publisher where image copying fails identify-im6.q16: insufficient image data in file
/tmp/mini_magick20210908-143-1b7oecp.jpg' @ error/jpeg.c/ReadJPEGImage_/1166.` 🤔 but I think that is unrelated)
@@ -6,7 +6,7 @@ | |||
FROM buildpack-deps | |||
|
|||
# Install chrome and its dependencies | |||
RUN apt-get update -qq && apt-get install -y libxss1 libappindicator1 libindicator7 | |||
RUN apt-get update -qq && apt-get install -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN apt-get update -qq && apt-get install -y |
We can remove this line (same with the other Dockerfiles changed here) as it is no longer installing any software with apt
59044b5
to
b3f7d98
Compare
The dependencies in question were removed from the remote repos, and are no longer required for Chromium to build.
Just raising that I've not forgotten about this, I am snowed under with some pretty hefty work and as this isn't affecting most people I've put it to the side just for now. |
Superseded by #513 |
The dependencies in question were removed from the remote repos, and are no longer required for Chromium to build.
Removing them outright is safe to do, and does not affect any development environment.
Associated issue: #508 - To test that this PR works, you can clear the cache by running
docker builder prune
in thegovuk-docker
folder.