Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies from Dockerfiles #507

Closed
wants to merge 1 commit into from

Conversation

Tetrino
Copy link
Contributor

@Tetrino Tetrino commented Aug 24, 2021

The dependencies in question were removed from the remote repos, and are no longer required for Chromium to build.

Removing them outright is safe to do, and does not affect any development environment.

Associated issue: #508 - To test that this PR works, you can clear the cache by running docker builder prune in the govuk-docker folder.

@Tetrino
Copy link
Contributor Author

Tetrino commented Aug 24, 2021

@kevindew This doesn't have to be pulled in, but as far as I can tell through looking, Chromium just doesn't need these anymore, nor does it affect our environment.

@ChrisBAshton
Copy link
Contributor

@Tetrino I wasn't able to test this by running docker builder prune (that only freed up 1.4KB, and the make whitehall command continued to use cached build steps).

But what I did do was check out the main branch of govuk-docker, and then add the --no-cache flag to the main Makefile. I then ran make whitehall (after running govuk-docker down on Whitehall in another terminal). The make succeeded - am I missing something?

@Tetrino
Copy link
Contributor Author

Tetrino commented Aug 26, 2021

@ChrisBAshton It is possible they returned the dependencies to the repo, or updated them. I will need to find extra time to test them when possible.

Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @Tetrino for digging into this, apologies I didn't notice this earlier

I too had the problem that docker builder prune didn't work, as that only removed dangling images. I think docker image prune -a will do the trick (but does nuke everything be warned).

Have you tested some projects can still run Chrome ok? I gave this ago myself and I'm pretty confident it works. I was able to run some JS Content Publisher feature tests (I did hit a different annoying issue in Content Publisher where image copying fails identify-im6.q16: insufficient image data in file /tmp/mini_magick20210908-143-1b7oecp.jpg' @ error/jpeg.c/ReadJPEGImage_/1166.` 🤔 but I think that is unrelated)

@@ -6,7 +6,7 @@
FROM buildpack-deps

# Install chrome and its dependencies
RUN apt-get update -qq && apt-get install -y libxss1 libappindicator1 libindicator7
RUN apt-get update -qq && apt-get install -y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN apt-get update -qq && apt-get install -y

We can remove this line (same with the other Dockerfiles changed here) as it is no longer installing any software with apt

The dependencies in question were removed from the remote repos, and are
 no longer required for Chromium to build.
@Tetrino
Copy link
Contributor Author

Tetrino commented Sep 24, 2021

Just raising that I've not forgotten about this, I am snowed under with some pretty hefty work and as this isn't affecting most people I've put it to the side just for now.

@kevindew
Copy link
Member

kevindew commented Oct 8, 2021

Superseded by #513

@kevindew kevindew closed this Oct 8, 2021
@kevindew kevindew deleted the remove_unneeded_dependencies branch October 8, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants