Organise JavaScript configuration documentation #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
colinrotherham
force-pushed
the
component-config
branch
from
df21a60
to
b28add7
Compare
colinrotherham
changed the base branch from
release/5.0
to
frontend-supported
romaricpascal
approved these changes
Dec 8, 2023
colinrotherham
force-pushed
the
frontend-supported
branch
from
8fdedbb
to
e8b73f4
Compare
This configuration section felt duplicated so we might as well move it but add some helpful links too
We have three clear sections for: * Nunjucks macro options * JavaScript configuration * HTML data attributes
colinrotherham
force-pushed
the
component-config
branch
from
b28add7
to
1a8e35e
Compare
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have lots of JavaScript examples split across:
This makes it difficult to add information about:
It's hard to document ways to import JavaScript when the "importing" page is full of configuration examples
Configuration shuffle
This PR adds a new Configure components page
It was previously called Configure components with JavaScript but we now have three clear sections for:
Where the Passing JavaScript configuration section is split further into:
In the next PR I'd like to move lots of Import CSS, assets and JavaScript JavaScript examples to this new page since they're related to configuration rather than importing
This gives us more freedom to use the Import CSS, assets and JavaScript for different import flavours