Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: Investigate CSS modules #1138

Closed
2 tasks done
hannalaakso opened this issue Jan 16, 2019 · 1 comment
Closed
2 tasks done

SPIKE: Investigate CSS modules #1138

hannalaakso opened this issue Jan 16, 2019 · 1 comment

Comments

@hannalaakso
Copy link
Member

hannalaakso commented Jan 16, 2019

What

Based on discussions in #1052, we could do a short spike to explore whether it's feasible for GOV.UK Frontend to support CSS modules by either:

  1. Generating an extra [filename].modules.scss file as part of the build process.
  2. Renaming our existing scss files to [filename].module.scss - this would be a breaking change.

Why

We know that some teams in the community use Create React App to build services. We'd like to explore whether we can support these teams by making our scss files follow the naming convention.

Tasks

  • Investigate options 1 and 2, as well as any other viable options
  • Make a recommendation on next steps
@hannalaakso hannalaakso added this to This sprint in Design System Sprint Board via automation Jan 16, 2019
@hannalaakso hannalaakso moved this from This sprint to In progress in Design System Sprint Board Jan 29, 2019
@NickColley
Copy link
Contributor

See #1052 (comment)

Design System Sprint Board automation moved this from In progress to Ready to release Feb 6, 2019
@NickColley NickColley moved this from Ready to release to Done in Design System Sprint Board Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants