Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA not assigning labels properly in date input component #1408

Closed
NickColley opened this issue May 31, 2019 · 3 comments
Closed

NVDA not assigning labels properly in date input component #1408

NickColley opened this issue May 31, 2019 · 3 comments
Labels
accessibility audit may 2019 Issues from May 2019 external accessibility audit, before version 3.0.0

Comments

@NickColley
Copy link
Contributor

This issue is from a May 2019 external accessibility audit report.

WCAG Reference: Usability feedback only, there is no WCAG related guidelines.
Issue ID: DAC_Issue24
URL: http://govuk-frontend-v3.herokuapp.com/full-page-examples/applicant-details
Page: Applicants details

Screen Shot


There were form fields present that were not appearing as labelled to users of NVDA in Firefox, although these had clearly been labelled.
This was due to the use of input type of ‘number’. This is a software issue but has been reported for informational purposes. The input type of number also does not allow voice commands to be used either.
However, this input type can be useful for users on a mobile or tablet device as it displays the correct keyboard.

Current Code Ref(s)

<input class="govuk-input govuk-date-input__input govuk-input--width-2" id="dob-day" name="dob-day" type="number" pattern="[0-9]*">

Screen reader comments

“With NVDA, while navigating out of context using the elements list ‘insert+f7’, the edit fields relating to the date of birth feature announced to me as “Unlabelled.” It might not be clear to some users using the elements list what the fields relate to. This did not occur using JAWS or VoiceOver for iPhone and Mac.”

Solution

Use the input type of ‘tel’ to ensure that all users can access and interact with text boxes as expected.

@NickColley NickColley added accessibility awaiting triage Needs triaging by team audit may 2019 Issues from May 2019 external accessibility audit, before version 3.0.0 labels May 31, 2019
@NickColley
Copy link
Contributor Author

As they mention in the audit, this is a bug with NVDA.

We do however know there are issues with type=number and there are some alternatives we could try.

I have put awaiting-triage on this so we can consider:

  1. Changing the component to use something other than type=number, for example exploring inputmode or type=tel.
  2. Reporting this bug and closing this issue.

@NickColley
Copy link
Contributor Author

We think we should try to test this in a device lab, if we change the implementation, for older browsers if possible.

@NickColley NickColley added Effort: days and removed awaiting triage Needs triaging by team labels Jun 4, 2019
@kellylee-gds kellylee-gds added this to Upcoming sprints in Design System Sprint Board via automation Jun 13, 2019
@kellylee-gds kellylee-gds moved this from Upcoming sprints to Sprint Backlog in Design System Sprint Board Jun 13, 2019
@36degrees 36degrees moved this from Sprint Backlog to Upcoming sprints in Design System Sprint Board Jul 9, 2019
@kellylee-gds kellylee-gds removed this from Upcoming sprints in Design System Sprint Board Sep 4, 2019
@36degrees 36degrees added this to Upcoming sprints in Design System Sprint Board via automation Jan 15, 2020
@36degrees 36degrees moved this from Upcoming sprints to Sprint Backlog in Design System Sprint Board Jan 15, 2020
@36degrees 36degrees removed this from Sprint Backlog in Design System Sprint Board Jan 17, 2020
@36degrees
Copy link
Contributor

Verified as fixed by #1704

Elements List 20_01_2020 17_05_08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility audit may 2019 Issues from May 2019 external accessibility audit, before version 3.0.0
Projects
None yet
Development

No branches or pull requests

2 participants