Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component tests to always use the YAML examples #1894

Closed
4 tasks done
vanitabarrett opened this issue Aug 3, 2020 · 0 comments · Fixed by #1924
Closed
4 tasks done

Update component tests to always use the YAML examples #1894

vanitabarrett opened this issue Aug 3, 2020 · 0 comments · Fixed by #1924
Assignees
Milestone

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Aug 3, 2020

Part of: #1830

What

  • Update component tests to consistently use the examples in the YAML files.
  • Update component tests and YAML examples to add any missing tests.
  • Add a flag to hide examples that we don't want shown in the GOVUK Frontend review app.
  • Add a html param and example to the fieldset component. It uses caller, but should have an alternative.

Why

We will be generating fixtures from these YAML examples. We want to make sure the YAML files properly represent what data can be passed to each component and that these are tested.

@vanitabarrett vanitabarrett added this to Upcoming sprints in Design System Sprint Board via automation Aug 3, 2020
@kellylee-gds kellylee-gds moved this from Upcoming sprints to Sprint Backlog in Design System Sprint Board Aug 5, 2020
@vanitabarrett vanitabarrett moved this from Sprint Backlog to In progress in Design System Sprint Board Aug 7, 2020
@vanitabarrett vanitabarrett self-assigned this Aug 7, 2020
@vanitabarrett vanitabarrett moved this from In progress to Needs review in Design System Sprint Board Aug 21, 2020
@36degrees 36degrees added this to the v3.9.0 milestone Sep 1, 2020
@vanitabarrett vanitabarrett moved this from Needs review to Ready to release in Design System Sprint Board Sep 2, 2020
@vanitabarrett vanitabarrett moved this from Ready to release to Done in Design System Sprint Board Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants