Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character count size changes when error state is applied #1910

Closed
36degrees opened this issue Aug 13, 2020 · 0 comments · Fixed by #1912
Closed

Character count size changes when error state is applied #1910

36degrees opened this issue Aug 13, 2020 · 0 comments · Fixed by #1912
Assignees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) character count
Milestone

Comments

@36degrees
Copy link
Contributor

The size of the character count changes when you go over the character limit.

Aug-13-2020 09-39-07

This is happening because we're still trying to compensate for the error state having a thicker border, which it no longer does since #1870.

.govuk-textarea--error {
padding: govuk-spacing(1) - 2; // Stop a "jump" when width of border changes
}

@36degrees 36degrees added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) character count labels Aug 13, 2020
@36degrees 36degrees added this to Upcoming sprints in Design System Sprint Board via automation Aug 13, 2020
@36degrees 36degrees self-assigned this Aug 13, 2020
@36degrees 36degrees moved this from Upcoming sprints to In progress in Design System Sprint Board Aug 13, 2020
@36degrees 36degrees moved this from In progress to Needs review in Design System Sprint Board Aug 13, 2020
@36degrees 36degrees added this to the v3.8.1 milestone Aug 13, 2020
@36degrees 36degrees moved this from Needs review to Ready to release in Design System Sprint Board Aug 13, 2020
@36degrees 36degrees moved this from Ready to release to Done in Design System Sprint Board Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) character count
Projects
Development

Successfully merging a pull request may close this issue.

1 participant