Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse mixin and modifier for links #1916

Closed
Tracked by #2197
36degrees opened this issue Aug 14, 2020 · 0 comments · Fixed by #2213
Closed
Tracked by #2197

Add inverse mixin and modifier for links #1916

36degrees opened this issue Aug 14, 2020 · 0 comments · Fixed by #2213

Comments

@36degrees
Copy link
Contributor

Links on dark backgrounds (like blue 'heros') are generally white.

Because of the way that the different states interact with each other, and the importance of the ordering of the selectors in the CSS, it's relatively easy to end up with the focus state being incorrectly applied – for example, with focused visited links being white on yellow:

image (5)

We should consider adding an govuk-link-style-inverse mixin and an govuk-link--inverse modifier for links that sets the text colour to white and correctly applies the different states.

@36degrees 36degrees added awaiting triage Needs triaging by team typography labels Aug 14, 2020
@kellylee-gds kellylee-gds added guidance documentation User requests new documentation or improvements to existing documentation 🕔 days and removed awaiting triage Needs triaging by team guidance labels Aug 17, 2020
@36degrees 36degrees added guidance and removed documentation User requests new documentation or improvements to existing documentation labels Aug 17, 2020
@36degrees 36degrees added this to Upcoming sprints in Design System Sprint Board via automation Apr 13, 2021
@36degrees 36degrees added this to the v3.12.0 milestone Apr 13, 2021
@36degrees 36degrees moved this from Upcoming sprints to In progress 📝 in Design System Sprint Board Apr 16, 2021
@36degrees 36degrees self-assigned this Apr 16, 2021
@36degrees 36degrees linked a pull request Apr 19, 2021 that will close this issue
12 tasks
@kellylee-gds kellylee-gds moved this from In progress 📝 to Needs review 🔍 in Design System Sprint Board Apr 20, 2021
@36degrees 36degrees removed a link to a pull request Apr 30, 2021
12 tasks
@36degrees 36degrees moved this from Needs review 🔍 to Ready to release 🚀 in Design System Sprint Board Apr 30, 2021
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in Design System Sprint Board May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants