Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create notification banner component #1935

Closed
13 tasks done
36degrees opened this issue Sep 1, 2020 · 1 comment
Closed
13 tasks done

Create notification banner component #1935

36degrees opened this issue Sep 1, 2020 · 1 comment
Labels
epic Epics are used in planning project boards to group related stories notification banner
Milestone

Comments

@36degrees
Copy link
Contributor

36degrees commented Sep 1, 2020

What

Create the notification banner component in GOV.UK Frontend.

Why

Having reviewed the feedback from the working group, we now need to build the component in Frontend ready for release.

Depends on

Further detail

Some specific bits of feedback worth considering from the working group and accessibility clinic findings:

  • it’s recommended we remove aria-labelledby from the markup for the red and the green banners as they’re not landmarks (https://www.w3.org/TR/wai-aria-1.1/#landmark_roles) and therefore the label will never be read out (the same actually applies to our current error summary)
  • we should explain the accessibility considerations – for example what the role= does – in comments in the code and/or tests.

Done when…

@36degrees 36degrees added this to Upcoming sprints in Design System Sprint Board via automation Sep 1, 2020
@36degrees 36degrees added this to the v4.0.0 milestone Sep 1, 2020
@kellylee-gds kellylee-gds moved this from Upcoming sprints to Sprint Backlog in Design System Sprint Board Sep 2, 2020
@hannalaakso hannalaakso moved this from Sprint Backlog to In progress in Design System Sprint Board Sep 16, 2020
@hannalaakso hannalaakso self-assigned this Sep 16, 2020
@hannalaakso hannalaakso moved this from In progress to Sprint Backlog in Design System Sprint Board Sep 16, 2020
@hannalaakso hannalaakso removed their assignment Sep 17, 2020
@36degrees 36degrees modified the milestones: v4.0.0, v3.10.0 Sep 23, 2020
@hannalaakso hannalaakso self-assigned this Sep 23, 2020
@hannalaakso hannalaakso moved this from Sprint Backlog to In progress in Design System Sprint Board Sep 23, 2020
@hannalaakso
Copy link
Member

I'm thinking that one thing we should highlight at the accessibility clinic is the approach of making the <p> tags look like headings when we have just a single line of content in the banner. We do this as we want to draw attention to the message in the banner and semantically you should haven't a heading tag that doesn't act as a heading for some content below it. However it'd be good to confirm that this isn't a concern as we're making an element look like another element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epics are used in planning project boards to group related stories notification banner
Projects
No open projects
Development

No branches or pull requests

4 participants