Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the review app consume govuk-frontend #3548

Closed
2 tasks done
Tracked by #3291
romaricpascal opened this issue Apr 25, 2023 · 0 comments · Fixed by #3491 or #3498
Closed
2 tasks done
Tracked by #3291

Make the review app consume govuk-frontend #3548

romaricpascal opened this issue Apr 25, 2023 · 0 comments · Fixed by #3491 or #3498
Milestone
v5.0

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Apr 25, 2023 •
edited by colinrotherham
Loading

What

We're making the review app actually use govuk-frontend rather than relative paths for reaching the JavaScript, Sass and Nunjucks files.

Why

This gives us a way to import files closer to what our users will experience. You can find more details about this decision in our decision log

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

Tasks
Beta Give feedback
  1. Update Review app to import govuk-frontend via local package #3491
    consistency dependencies interoperability
    colinrotherham
  2. Remove built govuk-frontend from committed files #3498
    consistency dependencies interoperability
    colinrotherham
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
1 participant
@romaricpascal