Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw errors during Radios and Checkboxes initialisation if key HTML elements are missing #4131

Closed
1 task
Tracked by #3478
domoscargin opened this issue Aug 24, 2023 · 1 comment · Fixed by #4236
Closed
1 task
Tracked by #3478

Throw errors during Radios and Checkboxes initialisation if key HTML elements are missing #4131

domoscargin opened this issue Aug 24, 2023 · 1 comment · Fixed by #4236
Assignees
@domoscargin
Labels
checkboxes javascript radios
Milestone
v5.0

Comments

@domoscargin
Copy link
Contributor

What

Update our JavaScript components requiring specific HTML elements to be present so they throw a MissingElementError (extending GOVUKFrontendError) rather than silently fail:

  • The <input> elements

Why

This is part of our work to have our components throw rather than silently return during initialisation.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Component has been updated to throw errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domoscargin domoscargin

Labels
checkboxes javascript radios
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Throw ElementError (not found) if checkboxes or radios have no input items alphagov/govuk-frontend
2 participants
@romaricpascal @domoscargin