Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin below final element in the Error Summary #4997

Closed
1 task
romaricpascal opened this issue May 21, 2024 · 0 comments · Fixed by #5060
Closed
1 task

Add margin below final element in the Error Summary #4997

romaricpascal opened this issue May 21, 2024 · 0 comments · Fixed by #5060

Comments

@romaricpascal
Copy link
Member

What

Add back a margin after the final element of the content in the Error Summary (either the final error in the list or the description).

Note: it might be that the margin does not necessarily need to be added back on the <li> it was removed from. The content is enclosed in the govuk-error-summary__body.

Why

We recently removed a 5px margin under the final <li> element in #4971, but it turns out that the extra margin can be helpful to account for descenders of letters like 'g', 'y', 'p'...

Who needs to work on this

Developers, designers

Who needs to review this

Developers, designers

Done when

  • Margins have been added back at the end of Error summary's content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog 🏃🏼‍♀️
Development

Successfully merging a pull request may close this issue.

1 participant