Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review application can mislead if a component is polyfilled #674

Closed
NickColley opened this issue Apr 26, 2018 · 2 comments
Closed

Review application can mislead if a component is polyfilled #674

NickColley opened this issue Apr 26, 2018 · 2 comments
Labels
feature request User requests a new feature javascript

Comments

@NickColley
Copy link
Contributor

NickColley commented Apr 26, 2018

Our review application uses the 'all' JavaScript bundle.

If a polyfill is defined in one component it can also solve issues in another component, without explicitly importing them.

We could consider only initialising components on their respective pages.

Work around: Uncomment other components when testing them.

This ties into #660

@kr8n3r
Copy link

kr8n3r commented Oct 23, 2018

Had a hard time trying to figure out why our classList polyfill wasn't working in IE8 tabs in the Design System.

Compared it to FT's script dependencies and found that it also needed the Element polyfill, which isn't imported in the our classList javascript file.

@36degrees
Copy link
Member

Closing as once we've done #2506 we'll no longer be manually including polyfills in our JavaScript code.

@36degrees 36degrees closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request User requests a new feature javascript
Projects
None yet
Development

No branches or pull requests

6 participants