Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Character count can show incorrect count when going 'back', or if page is discarded and restored #1848

Closed
36degrees opened this issue Jun 26, 2020 · 0 comments · Fixed by #1868
Closed

Character count can show incorrect count when going 'back', or if page is discarded and restored #1848

36degrees opened this issue Jun 26, 2020 · 0 comments · Fixed by #1868
Assignees
@vanitabarrett
Labels
character count
Projects
Design System Sprint Board
Milestone
v3.8.0

Comments

@36degrees
Copy link
Member

The character count can show the incorrect count when navigating back in the browser, or if the page is discarded and restored.

This is because the component is initialised before the form control state is restored, and is very similar to the issue described in #1794 and fixed in #1842.

Because of the similarity with those issues, I suspect this will affect Chromium browsers > 79 and Internet Explorer 8-11.
@36degrees 36degrees added character count awaiting triage Needs triaging by team labels Jun 26, 2020
@36degrees 36degrees added this to Upcoming sprints in Design System Sprint Board via automation Jul 6, 2020
@kellylee-gds kellylee-gds added 🕔 days and removed awaiting triage Needs triaging by team labels Jul 6, 2020
@36degrees 36degrees moved this from Upcoming sprints to Sprint Backlog in Design System Sprint Board Jul 7, 2020
@vanitabarrett vanitabarrett moved this from Sprint Backlog to In progress in Design System Sprint Board Jul 13, 2020
@vanitabarrett vanitabarrett self-assigned this Jul 13, 2020
@vanitabarrett vanitabarrett mentioned this issue Jul 16, 2020
Merged
14 tasks
@vanitabarrett vanitabarrett moved this from In progress to Needs review in Design System Sprint Board Jul 16, 2020
@vanitabarrett vanitabarrett moved this from Needs review to Ready to release in Design System Sprint Board Jul 16, 2020
@36degrees 36degrees added this to the v3.8.0 milestone Jul 21, 2020
@vanitabarrett vanitabarrett mentioned this issue Jul 29, 2020
Merged
@vanitabarrett vanitabarrett moved this from Ready to release to Done in Design System Sprint Board Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vanitabarrett vanitabarrett

Labels
character count
Projects
GOV.UK Design System cycle board
Archived in project
Design System Sprint Board
  
Done 🏁
Milestone
v3.8.0
Development

Successfully merging a pull request may close this issue.

Preserve the state of character count when navigating 'back' alphagov/govuk-frontend
3 participants
@36degrees @vanitabarrett @kellylee-gds