Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

Consider adding rubocop-rspec #80

Closed
floehopper opened this issue Jul 26, 2017 · 1 comment
Closed

Consider adding rubocop-rspec #80

floehopper opened this issue Jul 26, 2017 · 1 comment
Assignees
@floehopper

Comments

@floehopper
Copy link
Contributor

When upgrading govuk-lint to v3.1.0 in asset-manager I ran into an issue where the Metrics/BlockLength rule now defaults to a maximum of 25 lines. While I think this is OK in general terms, it's a bit problematic in DSL-style code, like RSpec specs.

I've seen this recommendation to to use rubocop-rspec and so I think it might be sensible to add this gem as a dependency of govuk-lint.

What do people think?
fofr added a commit to alphagov/government-frontend that referenced this issue Jul 27, 2017
@fofr
Reduce length of blocks over 25 lines
f30276a 
* Fix linter errors by reducing block sizes
* Disable BlockLength linting for tests as many of the lines are needed
for test fixtures

See also:
alphagov/asset-manager@53d4b970751ec1
fbb750d9e08ebdb83034b48f9e
alphagov/govuk-lint#80
@floehopper floehopper mentioned this issue Jul 28, 2017
Closed
fofr added a commit to alphagov/government-frontend that referenced this issue Jul 28, 2017
@fofr
Reduce length of blocks over 25 lines
5885c18 
* Fix linter errors by reducing block sizes
* Disable BlockLength linting for tests as many of the lines are needed
for test fixtures

See also:
alphagov/asset-manager@53d4b970751ec1
fbb750d9e08ebdb83034b48f9e
alphagov/govuk-lint#80
@floehopper floehopper self-assigned this Sep 14, 2017
@floehopper floehopper mentioned this issue Sep 14, 2017
Merged
@floehopper
Copy link
Contributor Author

This was addressed in #83. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@floehopper floehopper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@floehopper