Fix _unchecked session removal for arrays

Using triple `=== ['_unchecked']` can never return `true`
alphagov · Oct 11, 2023 · bc86613 · bc86613
1 parent 89a909c
commit bc86613
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/session.js b/lib/session.js
@@ -59,7 +59,7 @@ function storeData (input, data) {
     let val = input[i]
 
     // Delete values when users unselect checkboxes
-    if (val === '_unchecked' || val === ['_unchecked']) {
+    if ([val].flat().every((item) => item === '_unchecked')) {
       delete data[i]
       continue
     }

diff --git a/lib/session.test.js b/lib/session.test.js
@@ -89,7 +89,7 @@ describe('autoStoreData', () => {
     }
     const expectedData = {
       checkBoxes1: ['cb1-1', 'cb1-2'],
-      checkBoxes2: [],
+      checkBoxes2: undefined,
       checkBoxes3: ['cb3-1', 'cb3-2'],
       existingData: 'existing data'
     }