Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write blocks to layout.html, not govuk_template.html #4

Closed
joelanman opened this issue Jul 23, 2014 · 1 comment
Closed

Write blocks to layout.html, not govuk_template.html #4

joelanman opened this issue Jul 23, 2014 · 1 comment
Labels
Feature Request User requests a new feature

Comments

@joelanman
Copy link
Contributor

with the current set up, views write directly to the content block in govuk_template.html

this means you can't define any common html in layout.html

we don't want people to edit govuk_template, so I think the best thing to do is make layout.html more "responsible" for everything - views should write to layout (which is editable) instead of govuk_template (which is not).

@tombye
Copy link
Contributor

tombye commented Jul 23, 2014

Can you explain with examples of what you mean in relation to the specific problem that caused this issue? It's hard to talk in the abstract about this.

tombye added a commit that referenced this issue Apr 20, 2015
gemmaleigh added a commit that referenced this issue Apr 20, 2015
joelanman added a commit that referenced this issue May 22, 2018
jonty-uk-gov-mirror pushed a commit to uk-gov-mirror/UKHomeOffice.home_office_design_kit that referenced this issue Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request User requests a new feature
Projects
None yet
Development

No branches or pull requests

2 participants