Open fewer files at once during migration. #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliecarey
force-pushed
the
open-fewer-files-concurrently
branch
from
bfc659b
to
f9eb590
Compare
BenSurgisonGDS
suggested changes
Sep 19, 2023
lib/utils/asyncSerialMap.spec.js
Outdated
| @@ -0,0 +1,64 @@ | |||
| const { asyncSeriesMap } = require('./asyncSeriesMap') | |||
| describe('asyncSerialMap', () => { | |||
| const nextTick = ms => new Promise((resolve) => { | |||
There was a problem hiding this comment.
I'm not sure why ms is a parameter here if it's not used in the function. Perhaps replace ms with ()
There was a problem hiding this comment.
Ah, it used to be a wait function before I realised it could be nextTick. I'll remove it.
nataliecarey
force-pushed
the
open-fewer-files-concurrently
branch
from
f9eb590
to
78c92d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to resolve an issue I was facing with a migration yesterday where there was a "too many files open" error for a large prototype. I'd expect this to be more reliable too as it's less likely to choke slower systems up.