Only ask for usage permission if TTY #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellylee-gds
added
Submitted by user
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-697
NickColley
approved these changes
Mar 4, 2019
36degrees
approved these changes
Mar 5, 2019
|
Sorry, actually there's one more thing – would you mind rebasing and adding an entry to the changelog? (We can do this if you prefer.) |
|
I've not got access to a computer this week; feel free to add the changelog
entry for me, or I'll do it this weekend.
…On Tue, 5 Mar 2019, 10:02 am Oliver Byford, ***@***.***> wrote:
Sorry, actually there's one more thing – would you mind adding an entry to
the changelog?
(We can do this if you prefer.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#697 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAx3nt7HVsVyYXU1YHkXcwoaQ0E3mNPqks5vTjKxgaJpZM4bRsy->
.
|
You can run the prototype toolkit in a way that does not accept input. A basic example would be: $ npm start | cat If this is the first time you have run the prototype kit, the application will hang as there is no way to respond to the question about recording usage data. This means it is difficult to run the prototype kit solely without user input. This commit changes the behaviour of that prompt to only appear if the user is running the command in a TTY context. If the user is not running the prototype kit in a TTY, the prompt will be skipped and the default action will occur as if the user had simply hit return. In this case, it'll default to "no" and opt the user out of usage data collection automatically. A downside of this approach is that the user will not get asked again if they subsequently run the kit interactively. However, it is unlikely that users will wish to run the prototype kit initially within a pipeline whilst also wishing to run it interactively at a later date. Closes alphagov#695. Another prompt occurs when the chosen port is in use, but this commit doesn't attempt to edit that.
NickColley
force-pushed
the
auto-optout-on-noninteractive
branch
from
919e98e
to
9644b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can run the prototype toolkit in a way that does not accept input.
A basic example would be:
$ npm start | cat
If this is the first time you have run the prototype kit, the
application will hang as there is no way to respond to the question
about recording usage data. This means it is difficult to run the
prototype kit solely without user input.
This commit changes the behaviour of that prompt to only appear if the
user is running the command in a TTY context.
If the user is not running the prototype kit in a TTY, the prompt will
be skipped and the default action will occur as if the user had simply
hit return. In this case, it'll default to "no" and opt the user out of
usage data collection automatically.
A downside of this approach is that the user will not get asked again
if they subsequently run the kit interactively. However, it is unlikely
that users will wish to run the prototype kit initially within a
pipeline whilst also wishing to run it interactively at a later date.
Closes #695.
Another prompt occurs when the chosen port is in use, but
this PR doesn't attempt to edit that (the other prompt is only going to show when things go wrong, whereas this prompt occurs on the initial run of the app, every time).
I haven't included tests as there's no existing tests for the usage data feature.