This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Update app deployment job #4344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| git clone "git@github.com:alphagov/${TARGET_APPLICATION}.git" | ||
| cd "$TARGET_APPLICATION/" | ||
| git checkout $TAG | ||
| rm -f Gemfile |
There was a problem hiding this comment.
You can specify the Gemfile to use with BUNDLE_GEMFILE
BUNDLE_GEMFILE=${WORKSPACE}/Gemfile bundle exec cap "$DEPLOY_TASK"
|
One small comment, otherwise 👍 |
| else | ||
| echo "---> No deploy.sh found, running 'bundle exec cap \"${DEPLOY_TASK}\"'" >&2 | ||
| exec bundle exec cap "$DEPLOY_TASK" | ||
| git clone "git@github.com:alphagov/${TARGET_APPLICATION}.git" |
There was a problem hiding this comment.
Are there any non-alphagov apps we would want to use this approach with?
This change allows us to use Capistrano recipes which are in the app repo (in public). This is good because it means more people can access stuff and see how it works. - We need to wipe the workspace because we're making clones inside clones (it only takes about a minute longer) - For existing apps the process should be exactly the same - For apps that aren't defined in alphagov-deployment, this change will use the Capistrano recipe from the app repo
alexmuller
force-pushed
the
update-deploy-app-jenkins-job
branch
from
730dfe8
to
7a715bc
Compare
|
Superceded by #4350 which we think is better! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to use Capistrano recipes which are in the app
repo (in public). This is good because it means more people can access
stuff and see how it works.
(it only takes about a minute longer)
use the Capistrano recipe from the app repo
the main alphagov-deployment (not the app's bundle)