This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Add Plek service uris for Draft Frontend #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenetic
force-pushed
the
add-plek-service-uris-for-frontend
branch
8 times, most recently
from
7c7b621
to
9f096af
Compare
cbaines
approved these changes
Feb 13, 2017
brenetic
changed the title
brenetic
force-pushed
the
add-plek-service-uris-for-frontend
branch
from
9f096af
to
b08b0f7
Compare
|
@tijmenb I think this will stop you receiving those errbit emails? |
brenetic
force-pushed
the
add-plek-service-uris-for-frontend
branch
from
b08b0f7
to
1dfc6dd
Compare
In the draft stack draft-frontend needs to make api calls to Mapit, Local Links Manager, Imminence and Rummager all of which are available with `draft` prepended to their uri. We now set them directly based on the app_domain with and so Plek will return the necessary uri.
brenetic
force-pushed
the
add-plek-service-uris-for-frontend
branch
from
1dfc6dd
to
bc54850
Compare
tijmenb
approved these changes
Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the draft stack draft-frontend needs to make api calls to both Mapit and Local Links Manager neither of which are available with
draftprepended to their uri.We now set them directly based on the app_domain with and so Plek will return the necessary uri.