This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Add S3 bucket config to Asset Manager #6137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're enhancing Asset Manager to upload files to, and serve files from S3. This PR sets the AWS environment variables required by Asset Manager. We're safe to use the standard AWS environment variable names because we rely on `govuk_setenv` to provide each application with its own environment. See the related PRs in asset-manager and govuk-terraform-provisioning: * alphagov/asset-manager#74 * alphagov/govuk-terraform-provisioning#125
10 tasks
danielroseman
approved these changes
Jul 20, 2017
|
Thanks @danielroseman! I'll get this merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're enhancing Asset Manager to upload files to, and serve files from
S3. This PR sets the AWS environment variables required by Asset
Manager.
We're safe to use the standard AWS environment variable names because we
rely on
govuk_setenvto provide each application with its ownenvironment.
See the related PRs in asset-manager and govuk-terraform-provisioning: