Don't init OpenTelemetry when in rails console.
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseanything
approved these changes
Jul 11, 2023
This fixes a bunch of annoying warnings on startup, avoids generating traces from interactive use by default, and probably reduces the chance of OOM when execing `rails console` inside a serving app container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of annoying warnings on startup, avoids generating traces from interactive use by default, and possibly reduces the chance of OOM when execing
rails consoleinside a serving app container.(Thought about putting the condition in
GovukOpenTelemetry::should_configure?but given that the condition is specific to the Rails use case, the Railtie seemed like the better/cleaner place to put it.)