Can't create new edition if scheduled

alphagov · Mar 7, 2014 · 1d2ce35 · 1d2ce35
1 parent 4bb4d42
commit 1d2ce35
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/app/models/edition.rb b/app/models/edition.rb
@@ -98,7 +98,7 @@ def in_progress_sibling
   end
 
   def can_create_new_edition?
-    subsequent_siblings.in_progress.empty?
+    !scheduled_for_publishing? && subsequent_siblings.in_progress.empty?
   end
 
   def meta_data

diff --git a/test/models/edition_scheduled_for_publishing_test.rb b/test/models/edition_scheduled_for_publishing_test.rb
@@ -63,12 +63,17 @@ class EditionScheduledForPublishingTest < ActiveSupport::TestCase
     end
 
     should "return false for #can_destroy?" do
-      edition = FactoryGirl.create(:edition, :scheduled_for_publishing)
+      edition = FactoryGirl.build(:edition, :scheduled_for_publishing)
       refute edition.can_destroy?
     end
 
+    should "return false for #can_create_new_edition?" do
+      edition = FactoryGirl.build(:edition, :scheduled_for_publishing)
+      refute edition.can_create_new_edition?
+    end
+
     should "allow transition to published state" do
-      edition = FactoryGirl.create(:edition, :scheduled_for_publishing)
+      edition = FactoryGirl.build(:edition, :scheduled_for_publishing)
       assert edition.can_publish?
     end
   end