Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't commit dependencies, bring closer to prototype kit #119

Merged
merged 5 commits into from Nov 17, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 17, 2015

Do not commit dependencies. Everything in /govuk comes from the govuk_template or govuk_frontend_toolkit and is pulled in automatically using npm install and then grunt tasks on start.

Updates to bring elements closer inline to current prototype kit:

  • Use a Hogan.js module
  • Move template config to lib
  • Use govuk_modules directory rather than govuk

Added a Wraith config to test for regressions (domain is set to localhost). On all pages there was 0% difference.

(Elements is still quite different to the latest prototype kit, but the kit isn't versioned and there's no changelog, so it's hard to make them match.)

cc @dsingleton @gemmaleigh

fofr added 5 commits Nov 16, 2015
It shouldn’t be in the `govuk` directory, as that gets generated by
grunt tasks.
Do not commit dependencies. Everything in `/govuk` comes from the
govuk_template or govuk_frontend_toolkit and is pulled in automatically
using `npm install` and then grunt tasks on start.
This matches the pattern used by the latest govuk_prototype_kit
Add Wraith so that regressions can be easily spotted. Runs against all
the main elements pages and some of the examples.

Usage:
On master run: wraith history config.yaml
On local branch run: wraith latest config.yaml
@fofr fofr changed the title Don't commit dependencies, bring closer inline with current prototype kit Don't commit dependencies, bring closer to current prototype kit Nov 17, 2015
@fofr fofr changed the title Don't commit dependencies, bring closer to current prototype kit Don't commit dependencies, bring closer to prototype kit Nov 17, 2015
@gemmaleigh
Copy link
Contributor

@gemmaleigh gemmaleigh commented Nov 17, 2015

Hi @fofr, thanks for these changes.

I've submitted an issue to the prototype kit, to tag the repo when the version is changed - which will make it easier to see the differences between the two.

I've tested deploying to Heroku with these changes and that works as expected so I am happy to merge.

cc. @dsingleton @robinwhittleton.

gemmaleigh added a commit that referenced this pull request Nov 17, 2015
Don't commit dependencies, bring closer to prototype kit
@gemmaleigh gemmaleigh merged commit e09e95e into master Nov 17, 2015
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Nov 17, 2015

💯

@dsingleton dsingleton deleted the update-prototype-kit branch Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.