Don't commit dependencies, bring closer to prototype kit #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shouldn’t be in the `govuk` directory, as that gets generated by grunt tasks.
Do not commit dependencies. Everything in `/govuk` comes from the govuk_template or govuk_frontend_toolkit and is pulled in automatically using `npm install` and then grunt tasks on start.
This matches the pattern used by the latest govuk_prototype_kit
Add Wraith so that regressions can be easily spotted. Runs against all the main elements pages and some of the examples. Usage: On master run: wraith history config.yaml On local branch run: wraith latest config.yaml
fofr
changed the title
fofr
changed the title
|
Hi @fofr, thanks for these changes. I've submitted an issue to the prototype kit, to tag the repo when the version is changed - which will make it easier to see the differences between the two. I've tested deploying to Heroku with these changes and that works as expected so I am happy to merge. |
gemmaleigh
added a commit
that referenced
this pull request
Nov 17, 2015
Don't commit dependencies, bring closer to prototype kit
|
💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not commit dependencies. Everything in
/govukcomes from the govuk_template or govuk_frontend_toolkit and is pulled in automatically usingnpm installand then grunt tasks on start.Updates to bring elements closer inline to current prototype kit:
libgovuk_modulesdirectory rather thangovukAdded a Wraith config to test for regressions (domain is set to
localhost). On all pages there was 0% difference.(Elements is still quite different to the latest prototype kit, but the kit isn't versioned and there's no changelog, so it's hard to make them match.)
cc @dsingleton @gemmaleigh