Fix table spacing #482
Merged
Fix table spacing #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `color` gets inherited from the `body` and doesn't need to be set. Furthermore, only setting the colour without also setting the background colour could cause issues for people needing to change colour settings.
Merged
|
Thanks @selfthinker & @edwardhorsford 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove right padding from last table cells.
I also removed the
colordeclaration as it isn't necessary.What problem does the pull request solve?
This is a design-y problem. Can a designer please fill this section in and explain what the problem is? @edwardhorsford raised it.
Ed: it makes things look neater, and matches the padding (or lack thereof) used on the other side.
Screenshots
Before
After
What type of change is it?
I'm not 100% sure if it's a breaking change? If it is, it's only breaking things minimally.