Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug in selection-buttons.js #267

Closed
glenjamin opened this issue Mar 14, 2016 · 2 comments
Closed

Possible bug in selection-buttons.js #267

glenjamin opened this issue Mar 14, 2016 · 2 comments

Comments

@glenjamin
Copy link

Hello!

We've just started using eslint, and it's flagged up a possible issue in selection-buttons.js - I think it's correct.

The reported error is that $elms https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/selection-buttons.js#L9 is not used.

It's assigned a little further down https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/selection-buttons.js#L19 - but then this variable is never used.

I think it should be this.$elms if I'm following correctly.
@NickColley NickColley mentioned this issue Jul 13, 2016
Merged
@gemmaleigh gemmaleigh mentioned this issue Jul 21, 2016
Closed
@gemmaleigh
Copy link
Contributor

This was fixed in #303.

@NickColley
Copy link
Contributor

Thanks @glenjamin for raising 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix this. reference in selection-buttons.js alphagov/govuk_frontend_toolkit
3 participants
@glenjamin @gemmaleigh @NickColley