Remove unused $elms variable in selection-buttons.js #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying this over from the govuk_prototype_kit repo. alphagov/govuk-prototype-kit@5caea24 efa4302572636a91288d58da0b566376f
tvararu
force-pushed
the
fix-elms-for-selection-buttons
branch
from
555c250
to
eeaed12
Compare
tvararu
changed the title
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #295
Turns out the
this.$elmswrite isn't necessary since it wasn't being done before anyway. It was being written to$elmsbut not being read from at any later point.cc @gemmaleigh