Increase button focus specificity to avoid being overridden #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've updated govuk_template link focus styles which now overrides our buttons
NickColley
changed the title
fofr
approved these changes
May 10, 2017
|
Happy with this as I've tested end to end with alphagov/static#1035 |
NickColley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've updated govuk_template link focus styles which now overrides our buttons
As seen in https://www.gov.uk/book-driving-test
Introduced here: alphagov/govuk_template@79466a4
This kind of bug will hopefully be much more obvious when we merge these two repos as part of the new GOV.UK Frontend project :)