Add support for GA Universal #421

gunjam · 2017-06-26T14:13:01Z

Google Analytics Universal provides a function ga that sends all
communication to Google Analytics. The sendGoogleAnalyticsEvent
function now checks if the ga function exists and if it does, uses it.

Port of commit 6bb47fd by @robyoung

NickColley · 2017-06-27T14:10:59Z

I noticed in the previous implementation there's some tests, is it possible to get this tested here?

gunjam · 2017-06-27T16:36:00Z

I've added in the missing unit tests from the previous version.

Ta.

robyoung · 2017-07-04T15:47:44Z

Wow! @gunjam I am super impressed. How did you find that commit? I'd forgetten I even worked on that project.

NickColley · 2017-07-17T09:15:29Z

This looks good to me, but I think will be a breaking change since it'll always favour the ga global (which should be fine but is a breaking behaviour) 👍

rpowis · 2018-02-14T10:22:59Z

Hi all. Is there any chance of getting this merged? Some of our services have updated to universal analytics and I'd love to get rid of our fork of the old repo.

NickColley

I have added a changelog entry and approved this.

Will need another approval from the team before this can be merged.

NickColley · 2018-09-14T13:19:26Z

Going to ping the Analytics community at GDS to see if they're OK with this change.

36degrees · 2018-09-14T13:29:59Z

javascripts/stageprompt.js

@@ -62,7 +62,11 @@
  }())

  GOVUK.performance.sendGoogleAnalyticsEvent = function (category, event, label) {
-    global._gaq.push(['_trackEvent', category, event, label, undefined, true])
+    if (global.ga && typeof global.ga === 'function') {
+      global.ga('send', 'event', category, event, label)


The sixth element in the trackEvent array means means that opt_noninteraction is true, which means that the 'event hit will not be used in bounce-rate calculation'.

Assuming we'd want the same behaviour with GA Universal, I think we'd want to make this:

global.ga('send', 'event', category, event, label, { nonInteraction: true })

as per https://developers.google.com/analytics/devguides/collection/analyticsjs/events#non_interaction_events?

I'm not a performance analyst however… there may be other better ways of achieving the same thing without hardcoding it.

It seems sensible to mirror them.

@rpowis would be good to get your thoughts on this.

yeah good spot @36degrees. i think this got overlooked for whatever reason in our forked version.

so as things stand, any page using universal tracking with an event on it has been adding to the bounce rate if that event hasn't been triggered? 😬

similar to the _gaq call, we probably don't want to add to the bounce rate in the majority of cases so i'd say let's default to { nonInteraction: true }.

having the ability to opt-in would be good but i don't think any services here are getting that granular with their analytics so i'm not sure it would need to be done as part of this PR.

NickColley · 2018-09-14T13:30:15Z

This doesnt seem to be used much internally at GDS, but rather a library used for external services: https://github.com/search?l=JavaScript&p=1&q=org%3Aalphagov+GOVUK.performance&type=Code

Update: I went through these and could not find any up to date usage of this.

@robyoung

Google Analytics Universal provides a function `ga` that sends all communication to Google Analytics. The `sendGoogleAnalyticsEvent` function now checks if the `ga` function exists and if it does, uses it. Port of commit 6bb47fd (https://git.io/vQs2t) by @robyoung

@robyoung

Ported from commit [6bb47fd](https://git.io/vQs2t) by @robyoung

36degrees

LGTM, but a couple of suggestions for the changelog entry.

36degrees · 2018-09-26T10:12:16Z

CHANGELOG.md

@@ -1,6 +1,13 @@
 # Unreleased

- Fix: Add support to show-hide-content.js for form fields with more varied characters: ([PR 403](https://github.com/alphagov/govuk_frontend_toolkit/pull/403))
+- Breaking change: Add support for GA Universal in stageprompt.js


Can we explain why this is a breaking change, and what users need to do?

Good shout will update

36degrees · 2018-09-26T10:12:37Z

CHANGELOG.md

- Fix: Add support to show-hide-content.js for form fields with more varied characters: ([PR 403](https://github.com/alphagov/govuk_frontend_toolkit/pull/403))
+- Breaking change: Add support for GA Universal in stageprompt.js
+
+  Also ensures that events triggered via GA Universal do not impact bounce-rate calculations,


Does this need mentioning, as it's not a change from anything that's been released?

Given we know of forks that do not include this, I think it's worth mentioning.

@36degrees

This matches the previous analytics track event function. From @36degrees: The sixth element in the trackEvent array means means that opt_noninteraction is true, which means that the 'event hit will not be used in bounce-rate calculation'. as per https://developers.google.com/analytics/devguides/collection/analyticsjs/events#non_interaction_events

NickColley · 2018-09-26T12:17:49Z

I have spoken to @gunjam and got their approval for the updates I have made.

36degrees · 2018-09-26T12:32:10Z

36degrees mentioned this pull request Oct 3, 2017

Update stageprompt.js alphagov/govuk_frontend_toolkit_npm#35

Closed

This was referenced Feb 14, 2018

stageprompt version included in minified application js doesn't cater for newer Google analytics.js hmrc/assets-frontend#913

Closed

Allow tracking with universal analytics hmrc/assets-frontend#914

Merged

NickColley force-pushed the master branch from a8388c7 to 3192836 Compare September 14, 2018 13:17

NickColley approved these changes Sep 14, 2018

View reviewed changes

NickColley force-pushed the master branch from 3192836 to 2cf847c Compare September 14, 2018 13:26

36degrees reviewed Sep 14, 2018

View reviewed changes

gunjam added 3 commits September 14, 2018 17:53

Add space after typeof

043f33c

Adding unit tests for stageprompt.js

70d0bb2

Ported from commit [6bb47fd](https://git.io/vQs2t) by @robyoung

NickColley force-pushed the master branch from 2cf847c to 2a06f62 Compare September 14, 2018 16:54

NickColley force-pushed the master branch 2 times, most recently from 7b827c5 to 0022fd4 Compare September 25, 2018 16:24

36degrees approved these changes Sep 26, 2018

View reviewed changes

NickColley and others added 2 commits September 26, 2018 13:15

Add CHANGELOG entry

c456922

NickColley force-pushed the master branch from 0022fd4 to 7551cdc Compare September 26, 2018 12:17

NickColley merged commit ee78008 into alphagov:master Sep 26, 2018

dependabot bot mentioned this pull request Mar 15, 2021

Bump govuk_frontend_toolkit from 5.0.3 to 9.0.0 Crown-Commercial-Service/digitalmarketplace-supplier-frontend#1381

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for GA Universal #421

Add support for GA Universal #421

gunjam commented Jun 26, 2017 •

edited

Loading

NickColley commented Jun 27, 2017

gunjam commented Jun 27, 2017

robyoung commented Jul 4, 2017

NickColley commented Jul 17, 2017

rpowis commented Feb 14, 2018 •

edited

Loading

NickColley left a comment

NickColley commented Sep 14, 2018

36degrees Sep 14, 2018

NickColley Sep 14, 2018

rpowis Sep 25, 2018 •

edited

Loading

NickColley commented Sep 14, 2018 •

edited

Loading

36degrees left a comment

36degrees Sep 26, 2018

NickColley Sep 26, 2018

36degrees Sep 26, 2018

NickColley Sep 26, 2018

NickColley commented Sep 26, 2018

36degrees commented Sep 26, 2018

Add support for GA Universal #421

Add support for GA Universal #421

Conversation

gunjam commented Jun 26, 2017 • edited Loading

NickColley commented Jun 27, 2017

gunjam commented Jun 27, 2017

robyoung commented Jul 4, 2017

NickColley commented Jul 17, 2017

rpowis commented Feb 14, 2018 • edited Loading

NickColley left a comment

Choose a reason for hiding this comment

NickColley commented Sep 14, 2018

36degrees Sep 14, 2018

Choose a reason for hiding this comment

NickColley Sep 14, 2018

Choose a reason for hiding this comment

rpowis Sep 25, 2018 • edited Loading

Choose a reason for hiding this comment

NickColley commented Sep 14, 2018 • edited Loading

36degrees left a comment

Choose a reason for hiding this comment

36degrees Sep 26, 2018

Choose a reason for hiding this comment

NickColley Sep 26, 2018

Choose a reason for hiding this comment

36degrees Sep 26, 2018

Choose a reason for hiding this comment

NickColley Sep 26, 2018

Choose a reason for hiding this comment

NickColley commented Sep 26, 2018

36degrees commented Sep 26, 2018

gunjam commented Jun 26, 2017 •

edited

Loading

rpowis commented Feb 14, 2018 •

edited

Loading

rpowis Sep 25, 2018 •

edited

Loading

NickColley commented Sep 14, 2018 •

edited

Loading