Fixes media player volume button overlap #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #853. Volume up and down buttons in the media player were overlapping the current volume percentage on focus. This fix keeps the large button touch area, but adjust the focus state to be smaller.
fofr
reviewed
Jul 18, 2017
| } | ||
| } | ||
|
|
||
| &:before { |
There was a problem hiding this comment.
Clever solution 💯
How does this look in IE8?
There was a problem hiding this comment.
@fofr looks like the player never worked in IE8... at least according to BrowserStack, all I get is JS errors on the original link. Looks fine visually (with this fix), but none of the functionality works.
NickColley
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853. Volume up and down buttons in the media player were overlapping the current volume percentage on focus. This fix keeps the large button touch area, but adjust the focus state to be smaller.
Before: volume button focus state overlaps the current volume percentage:
After: volume button touch area remains the same as previously, but focus state is smaller so as not to obscure current volume percentage:
This shows the new focus state:
But we can see that the touch area remains the same:
This means the volume controls continue to work on small devices where all icons are more closely located together:
