Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link buttons do not have draggable=false #1558

Closed
NickColley opened this issue Jun 5, 2020 · 0 comments · Fixed by #2448
Closed

Link buttons do not have draggable=false #1558

NickColley opened this issue Jun 5, 2020 · 0 comments · Fixed by #2448
Assignees
Labels

Comments

@NickColley
Copy link
Contributor

Was just looking at this for something else at the FT and noticed GOV.UK Frontend has 'draggable=false' set on link buttons but this has not been ported to here.

I think this'll be a quick fix, I hope:

See original pull request that introduced it: alphagov/govuk-frontend#1020 (comment)

Should be able to check if the element is a link and set draggable false here: https://github.com/alphagov/govuk_publishing_components/blob/master/lib/govuk_publishing_components/presenters/button_helper.rb

And then there'd need to be a small test added.

@alex-ju alex-ju added enhancement accessibility Accessibility issues identified labels Jun 9, 2020
@owenatgov owenatgov self-assigned this Nov 12, 2021
@andysellick andysellick added this to In progress in Component issues Nov 15, 2021
Component issues automation moved this from In progress to Done Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants