Update document list with description #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
update-document-list-design
branch
from
f278063
to
b07131e
Compare
maxgds
previously requested changes
Mar 8, 2018
| <%= item[:metadata][:document_type] %> | ||
| </li> | ||
| </ul> | ||
| <p class="gem-c-document-list__item-description" ><%= item[:link][:description] %></p> |
There was a problem hiding this comment.
Since the description is optional we should check for it before writing paragraph tags.
vanitabarrett
force-pushed
the
update-document-list-design
branch
from
b07131e
to
468d5f0
Compare
vanitabarrett
force-pushed
the
update-document-list-design
branch
from
468d5f0
to
b7b38af
Compare
vanitabarrett
force-pushed
the
update-document-list-design
branch
from
b7b38af
to
f7090f0
Compare
We want to make use of the document list component on topic pages. For mainstream services, we want to show a description of the document rather than metadata. In the future, we may also want to supply additional metadata for each document, such as organisation and collection the document belongs to. This PR refactors the component to stop it being limited to only updated date and document type
vanitabarrett
force-pushed
the
update-document-list-design
branch
from
f7090f0
to
385ee92
Compare
This was referenced Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make use of the document list component on topic pages. For mainstream services, we want to show a description of the document rather than metadata.
In the future, we may also want to supply additional metadata for each document, such as organisation and collection the document belongs to. This PR refactors the component to stop it being limited to only updated date and document type
Component Guide Link: https://govuk-publishing-compon-pr-202.herokuapp.com/component-guide/document_list