Add margin_top flag to feedback component #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
add-margin-flag-feedback-component
branch
from
cf02572
to
b875451
Compare
maxgds
requested changes
Mar 15, 2018
| @@ -1,8 +1,10 @@ | |||
| <% | |||
| contact_govuk_path = "/contact/govuk" | |||
| margin_top||= 1 | |||
There was a problem hiding this comment.
missing space before the ||
| @@ -1,8 +1,10 @@ | |||
| <% | |||
| contact_govuk_path = "/contact/govuk" | |||
| margin_top||= 1 | |||
| margin_top_class = "gem-c-feedback--top-margin" if margin_top == 1 | |||
Topic pages need the feedback component to be flush with the bottom of the taxon grid. We therefore need to be able to add a flag to remove the top margin in these cases
vanitabarrett
force-pushed
the
add-margin-flag-feedback-component
branch
from
b875451
to
25ecf4d
Compare
|
@maxgds Added the missing space 👍 For the second comment, I think the |
|
I thought if it was set to false it would be the same as not existing in the evaluation, but happy to take your word for it. |
maxgds
approved these changes
Mar 15, 2018
|
@maxgds Ah okay, I was following a pattern for another component where we pass |
Merged
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic pages need the feedback component to be flush with the bottom of the taxon grid. We therefore need to be able to add a flag to remove the top margin in these cases
Example use on a topic page: