Use new grid layout placeholders for the cookie and header bar #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.inner-block` and `.outer-block` have been deprecated, remove these and replace with the new grid layout placeholders. This affects the global header bar (the blue line underneath the header) and the global cookie message (shown at first visit, or when js is disabled).
gemmaleigh
changed the title
|
This makes the code much nicer. Thanks for this @gemmaleigh! |
edds
added a commit
that referenced
this pull request
Jan 22, 2015
…from-header Use new grid layout placeholders for the cookie and header bar
|
This is 👍, long live the new grid. Is there a risk of anyone hanging styles/behaviour off the removed selectors? Might be worth mentioning in release notes when we do. |
|
The only thing I can think of - I didn't want to start adding extra |
gemmaleigh
pushed a commit
to alphagov/govuk_elements
that referenced
this pull request
Jun 4, 2015
# 0.13.0
- Add `homepage_url` for overriding the href for the header logo link
("https://www.gov.uk" by default)
- Add `global_header_text` for overriding the header logo text
("GOV.UK" by default)
- Removed deprecated grid layout mixins:
alphagov/govuk_template#129
gemmaleigh
pushed a commit
to alphagov/govuk-prototype-kit
that referenced
this pull request
Jun 4, 2015
# 0.13.0
- Add `homepage_url` for overriding the href for the header logo link
("https://www.gov.uk" by default)
- Add `global_header_text` for overriding the header logo text
("GOV.UK" by default)
- Removed deprecated grid layout mixins:
alphagov/govuk_template#129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inner-blockandouter-blockhave been deprecated, remove theseand replace with the new grid layout placeholders.
This affects the global header bar (the blue line underneath the
header) and the global cookie message (shown at first visit, or when js
is disabled).
Smaller screens:
Tablet:
Desktop:
