Allow skiplink target to be overridden #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also split this into another issue to avoid styling based on skip links. I'd propose:
|
quis
force-pushed
the
allow-overiding-of-skiplink
branch
from
02b8069
to
d8280bb
Compare
|
@NickColley That would cause breaking changes for consumers of Template and Elements. Feels overkill to fix my rather specific problem – even if the end result would be more robust/self-explanatory. |
GOV.UK Template hardcodes the skiplink to point at #content. But sometimes using `#content` introduces unwanted styling from 3rd parties (eg [in GOV.UK Elements](https://github.com/alphagov/govuk_elements/blob/d6226bd2c8c7e256f995c0f519daaa4035c6bd54/public/sass/elements/_layout.scss#L9-L20) ). This commit allows users of the template to set their own target for the skiplink. They will still need to include the target element in their pages, same as they have to for `id='content'` at the moment.
quis
force-pushed
the
allow-overiding-of-skiplink
branch
from
d8280bb
to
89ae3e1
Compare
quis
added a commit
to alphagov/notifications-admin
that referenced
this pull request
Feb 14, 2017
We didn’t have an element with an `id` of `content` on the product page because we didn’t want the styles that come with it (from GOV.UK Elements here: https://github.com/alphagov/govuk_elements/blob/d6226bd2c8c7e256f995c0f519daaa4035c6bd54/public/sass/elements/_layout.scss#L9-L20) This meant that the skiplink didn’t work on the product page because it’s target was not on the page. The skiplink’s target is hardcoded to point at `#content`. The proper way to fix this would be to not hardcode the skiplink to point at `#content`, ie what this pull request does: alphagov/govuk_template#275 Until that is merged, we can hack around the problem by overriding the styles that Elements applies to `#content`, which is what this pull request does.
|
@quis, would you be able to update this to fix the failing tests? |
|
Following the launch of the GOV.UK Design System, GOV.UK Template will now only get major bug fixes and security patches, so I'm going to close this. The issue that this PR addresses has been captured on GOV.UK Frontend here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
GOV.UK Template hardcodes the skiplink to point at
#content. But sometimes using#contentintroduces unwanted styling from 3rd parties (eg in GOV.UK Elements).This commit allows users of the template to set their own target for the skiplink. They will still need to include the target element in their pages, same as they have to for
id='content'at the moment.