Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError: key not found: "file" #920

Closed
floehopper opened this issue Mar 27, 2017 · 1 comment
Closed

KeyError: key not found: "file" #920

floehopper opened this issue Mar 27, 2017 · 1 comment
Assignees

Comments

@floehopper
Copy link
Contributor

This exception recently occurred in production and I thought we should investigate whether it's occurring due to a bug in the code.

@floehopper
Copy link
Contributor Author

I've reproduced this locally by editing an existing attachment via the link on the Edit Section page and just clicking "Save attachment" without selecting a file.

There should be some validation in place to protect against this, but given the current state of the codebase, it's unclear what the best way to fix it is without introducing unnecessary complexity.

So I've decided to open a new issue which we will aim to tackle once the code is in an easier to understand state.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant