Bring "lint" Rake task into line with "Lint Ruby" stage on CI #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the task description this is supposed to mimic the "Lint Ruby" stage run on Jenkins CI [1,2]. I've updated the `govuk-lint-ruby` options and directories in the Rake task to more closely match those used in the CI stage. Note that this means we are now only checking code that has changed. Ideally we'd be checking all the code every time, but if we want to do that we should change the Jenkins CI build to do the same. Note also that we are no longer checking the following directories: `bin`, `config` & `features`. If we decide we want to do this then we should chage the Jenkins CI build to do the same. I did contemplate trying to change the Jenkins CI build, but there doesn't seem to be an easy way to do this with the current `govuk_jenkinslib.groovy` code. [1]: https://github.com/alphagov/govuk-puppet/blob/43af3ededf1fc289d63bbac3969176bed76ce147/modules/govuk_jenkins/files/var/lib/jenkins/groovy_scripts/govuk_jenkinslib.groovy#L138-L140 [2]: https://github.com/alphagov/govuk-puppet/blob/43af3ededf1fc289d63bbac3969176bed76ce147/modules/govuk_jenkins/files/var/lib/jenkins/groovy_scripts/govuk_jenkinslib.groovy#L378-L396
floehopper
force-pushed
the
make-lint-rake-task-more-similar-to-linting-on-jenkins-ci
branch
from
2ac3a26
to
5f79cfe
Compare
chrislo
approved these changes
May 8, 2017
|
Good idea! As we just discussed there's probably some other changes we'd like to make around this and I see you're adding issues for them as I type :) |
|
@chrislo: Thanks. Yes, I've added a list of them to the description of this PR. Merging. |
floehopper
deleted the
make-lint-rake-task-more-similar-to-linting-on-jenkins-ci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the task description this is supposed to mimic the "Lint Ruby" stage run on Jenkins CI (see these lines & these lines). I've updated the
govuk-lint-rubyoptions and directories in the Rake task to more closely match those used in the CI stage.Note that this means we are now only checking code that has changed. Ideally we'd be checking all the code every time, but if we want to do that we should change the Jenkins CI build to do the same. It was very confusing that the two did not do the same thing.
Note also that we are no longer checking the following directories:
bin,config&features. If we decide we want to do this then we should chage the Jenkins CI build to do the same.I did contemplate trying to change the Jenkins CI build, but there doesn't seem to be an easy way to do this with the current
govuk_jenkinslib.groovycode.I've created the following issues to capture things that have come up while investigating this: