Remove ManualsPublisherWiring #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2017
Closed
chrislo
added a commit
to freerange/manuals-publisher
that referenced
this pull request
Mar 6, 2017
|
In this comment @h-lame recommended only merging this when #799 had been merged. That PR has since been merged, so there's no longer any need to hold off on this one. |
floehopper
approved these changes
Mar 7, 2017
There was a problem hiding this comment.
I previously reviewed #798, so I've confined my review to checking that all the feedback in that PR has been addressed in this PR.
|
I'm going to rebase this on master and force-push in preparation for merging. |
The `:manual_builder` and `:manual_document_builder` are the only entries in `ManualsPublisherWiring.get` whose name ends in `_builder`. Making this explicit should help me remove the `ManualsPublisherWiring` in future.
Note that `ManualPublishingApiBulkDraftExporter` takes `wiring` as a parameter. I'm presuming that it's an instance of `ManualsPublisherWiring`. I'm not worried about investigating too much further as `ManualPublishingApiBulkDraftExporter` doesn't appear to be instantiated anywhere anyway!
This does not appear to be used.
As in the commit title "Inline :repository_registry", I'm assuming that the `wiring` passed to `ManualPublishingAPIBulkDraftExporter` is a `ManualsPublishingWiring`. I can't be sure because `ManualPublishingAPIBulkDraftExporter` doesn't appear to be instantiated.
Note that this is memoised using a class instance variable as it was previously defined as a singleton.
Note that this is memoised using a class instance variable as it was previously defined as a singleton.
Note that this is memoised using a class instance variable as it was previously defined as a singleton.
Note that this is memoised using a class instance variable as it was previously defined as a singleton.
Note that this is memoised using a class instance variable as it was previously defined as a singleton.
Now that it's no longer being used.
floehopper
force-pushed
the
remove-manuals-publisher-wiring
branch
from
92951e4
to
ccc877a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes PR #798.
This branch simplifies the app by removing the level of indirection introduced in the
ManualsPublisherWiringclass.The changes in this branch and the feedback on PR #798 have revealed a number of further questions/improvements that we'll tackle separately:
ManualDocumentRendererandSpecialistDocumentRenderer(Investigate the difference between rendering pipelines ofManualDocumentRendererandSpecialistDocumentRenderer#810).Servicesmodule to hold singleton instances of various API clients (Introduce aServicesmodule to hold singleton instances of various API clients #811).