Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for PDF attachment report #814

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Add script for PDF attachment report #814

merged 1 commit into from
Mar 8, 2017

Conversation

neilvanbeinum
Copy link
Contributor

@neilvanbeinum neilvanbeinum commented Feb 27, 2017

Trello card

This script produces a CSV of counts of published PDF attachments per
organisation owning the associated manual. This was produced for the
Content Operating Model team as a custom report.

Also see (alphagov/specialist-publisher#1007) and (alphagov/whitehall#3036).

@neilvanbeinum neilvanbeinum force-pushed the pdf-report branch 3 times, most recently from 72bb02a to 9fd71b3 Compare February 27, 2017 16:36
@neilvanbeinum neilvanbeinum force-pushed the pdf-report branch 4 times, most recently from 95f3264 to d123c56 Compare March 8, 2017 12:15
@chrislo
Copy link
Contributor

chrislo commented Mar 8, 2017

@NeilvB - we booked in a deploy for Thursday, so feel free to merge this before then if you'd like it to go out as part of that deploy.

This script produces a CSV of counts of published PDF attachemnts per
organisation owning the associated manual. This was produced for the
Content Operating Model team.
@neilvanbeinum
Copy link
Contributor Author

Thanks @chrislo !

@neilvanbeinum neilvanbeinum merged commit 3ce157f into master Mar 8, 2017
@neilvanbeinum neilvanbeinum deleted the pdf-report branch March 8, 2017 12:55
@chrislo
Copy link
Contributor

chrislo commented Mar 8, 2017

In a discussion on the GDS Slack (#manuals-publisher channel, not publicly archived) @NeilvB pointed out that this script may be used by the requester again in the future. @h-lame was concerned that if we delete it from the codebase after running it may make it more difficult for future people to find it.

Given those two constraints, and that some time might pass before the script needs to be run again, I think this script should have some tests added so that we can be more confident that our future refactorings don't break it.

@chrislo
Copy link
Contributor

chrislo commented Mar 8, 2017

@NeilvB could you also add some of the relevant context for this request to the PR from the non-public Trello card, just in case someone else needs to refer to it in the future?

@chrisroos
Copy link
Contributor

Note that tests were added for this script in PR #830.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants