Introduce Services module #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floehopper
approved these changes
Mar 16, 2017
This removes some duplication and will make it clearer that this needs to change when I introduce a `Services` module to hold the various API clients.
Using a `Services` module to keep all the GdsApi clients together is a pattern used in a number of other GOV.UK apps. I'm manually requiring "services" where appropriate as the lib directory isn't in the array of `autoload_paths`.
Using a `Services` module to keep all the GdsApi clients together is a pattern used in a number of other GOV.UK apps. I'm manually requiring "services" where appropriate as the lib directory isn't in the array of `autoload_paths`. Note that we're already requiring "services" in abstract_manual_document_service_registry.rb so I haven't had to require it again.
Using a `Services` module to keep all the GdsApi clients together is a pattern used in a number of other GOV.UK apps. I'm manually requiring "services" where appropriate as the lib directory isn't in the array of `autoload_paths`.
Using a `Services` module to keep all the GdsApi clients together is a pattern used in a number of other GOV.UK apps. I'm manually requiring "services" where appropriate as the lib directory isn't in the array of `autoload_paths`. Note that we're already requiring "services" in section_reslugger.rb so I haven't had to require it again.
Using a `Services` module to keep all the GdsApi clients together is a pattern used in a number of other GOV.UK apps. I'm manually requiring "services" where appropriate as the lib directory isn't in the array of `autoload_paths`.
Using a `Services` module to keep all the GdsApi clients together is a pattern used in a number of other GOV.UK apps. Note that we're already requiring "services" in section_reslugger.rb so I haven't had to require it again.
I had a quick look at how other apps are instantiating |
I've somewhat arbitrarily chosen `Plek.find` but this could just as easily be `Plek.new.find` or `Plek.current.find`.
chrisroos
force-pushed
the
introduce-services-module
branch
from
5eafccf
to
b999ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a
Servicesmodule to keep all the GdsApi clients together is a pattern used in a number of other GOV.UK apps.As suggested by @h-lame.
Fixes issue #811.