Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation from the Ops Manual #945

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

klssmith
Copy link
Contributor

@klssmith klssmith commented Apr 4, 2017

We are moving documentation out of the Ops Manual - this commit adds the
documentation about manuals-publisher from the Ops Manual to this repo.

Trello card

We are moving documentation out of the Ops Manual - this commit adds the
documentation about manuals-publisher from the Ops Manual to this repo.

Trello:
https://trello.com/c/5x8NHLhf/40-merge-opsmanual-into-developer-docs
@chrisroos chrisroos self-assigned this Apr 4, 2017
@chrisroos
Copy link
Contributor

I can see that this content has been copied from https://github.gds/gds/opsmanual/blob/master/2nd-line/applications/manuals-publisher.rst.

I've also noticed that the remove_draft_manual_section script mentioned in the docs no longer exists but I'm going to create an issue to prompt us to investigate that separately.

@chrisroos chrisroos self-requested a review April 4, 2017 10:57
Copy link
Contributor

@chrisroos chrisroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chrisroos
Copy link
Contributor

@klssmith: Are you happy to merge this or would you like us to do it?

@chrisroos
Copy link
Contributor

I've created issue #946 to prompt us to investigate the missing remove_draft_manual_section script.

@tijmenb tijmenb merged commit b9924a3 into master Apr 4, 2017
@tijmenb tijmenb deleted the add-ops-manual-documentation branch April 4, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants