Fix issue where row_number starts from 3 on a job report download #1077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a job report download starts with a
row_number
of 3.Issue
We were originally checking to see if a row_number existed with
if dict.get('row_number')...
. This however evaluated toFalse
if a row_number was0
. We were also incrementing the row number by2
in the format, so the minimum number we could ever format to was3
.Fix
Changed the format to explicitly check for
0
and ensure we only increment by1
. The ensures if a row number is: