Add GOVUK Frontend details component #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombye
force-pushed
the
add-govuk-frontend-details
branch
from
b96f5bd
to
0ee04f0
Compare
|
Rebased this to sit it on top of the changes that removed the |
tombye
force-pushed
the
add-govuk-frontend-details
branch
from
0ee04f0
to
27473c3
Compare
Includes: - in gulpfile.js: - add details macro to list of those copied from GOVUK Frontend - remove existing details polyfill - convert all, but one, <details> tags to use GOVUK Frontend details component - add jinja boolean filter to help setting 'open' attribute of <details> tags Notes on the `<details>` not included in this: The `<details>` used for notifications items on the API integration page is not possible to reproduce with the GOV.UK Frontend macro so I'm splitting the resulting work out into it's own commit.
The GOV.UK Frontend details component macro wraps its `<summary>` text in a `<span>`. We put a `<h3>` in the `<summary>` (actually valid use, based on the spec) so this breaks when the `<span>` wraps it. This converts the existing `<details>` tag to use all the class names the macro creates, but with all the `<summary>` contents in the `<h3>`. Also adds font-smoothing to the messages on the API page. This was previously set globally for all fonts in the GOV.UK Template CSS but is now just set for the New Transport 'nta' font. Included because the messages use the monospace font so don't have it by default.
I moved the meta for each message into the `<h3>` in each `<summary>` to make the heading unique. This broke the test.
tombye
force-pushed
the
add-govuk-frontend-details
branch
from
27473c3
to
db3bcee
Compare
We're now using the GOV.UK Frontend one.
idavidmcdonald
approved these changes
Dec 13, 2019
This was referenced Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all macros for
<details>tags in the app to use the GOVUK Frontend details component.The
<details>on the API integration page cannot use the new component:It separates the content of its
<summary>tag into text that has the 'link style' and text that doesn't. The GOVUK Frontend component doesn't support this at present so we have to cut-and-paste the HTML it produces instead.