Make create account button more buttony #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`role=button` for users of voice control software `draggable=false` as per alphagov/govuk-frontend#1020
idavidmcdonald
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Appears that we have 4 other link buttons in the admin app which could also take advantage of the draggable false behaviour but I'm happy to let this PR go in as is and assume that will be taken care of automatically when we move links over to use the design system?
|
@idavidmcdonald Yeah, once the buttons are using the Design System they get this automatically. Because the Create account button isn’t in the Design System we have to fix it separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
role=buttonfor users of voice control softwaredraggable=falseas per alphagov/govuk-frontend#1020