Re-add Google Analytics #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f31170f.
If all our URLs are unique (because they contain service/job/template IDs) then it makes it hard to aggrate how users are behaving across a range of services/jobs/templates. This commit replaces anything that looks like a UUID in a URL with `…`.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Remove Google Analytics"
This reverts commit f31170f.
Remove UUIDs from URLs sent to Google Analytics
If all our URLs are unique (because they contain service/job/template IDs) then it makes it hard to aggregate how users are behaving across a range of services/jobs/templates.
This commit replaces anything that looks like a UUID in a URL with
….Regex taken from http://stackoverflow.com/a/18516125/147318