Bump tech docs to bring in accessibility fixes #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in a bunch of accessibility fixes: https://github.com/alphagov/tech-docs-gem/blob/master/CHANGELOG.md#240 (And a few patches for bugs found along the way.) This also bumps the ffi gem which caused this issue: ffi/ffi#791 The fix at the moment is just to keep ffi at 1.12 until the issue is resolved so this also adds that to the Gemfile. There is an issue on govuk_tech_docs to pin ffi there instead of downstream apps so we should revert our pin if this happens: alphagov/tech-docs-gem#254
klssmith
reviewed
Jul 30, 2021
Bump the date to today.
See this issue for details: alphagov/tech-docs-gem#254
klssmith
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In April 2020, a DAC audit of GovWifi tech docs found some more accessibility issues with the tech doc template.
The GovWiFi team fixed the majority of them. Bumping the
govuk_tech_docsgem brings in these fixes.I've tested all the issues from those raised, which effect our docs, and can see they are all fixed.