Move from moment to native Date object backed with date-fns

[paroxp]

What

moment is EOL. We should be moving off it.

moment, although has served its purpose, has been somewhat opinionated and specific, which caused our codebase to purely rely on moment.Moment and moment.Duration types. This makes it difficult to move off, upgrade or maintain the code.

We've had a chat, and decided that native Date, should be preferably used throughout the codebase, to maintain the simplicity and potential for us to migrate/maintain when necessary.

I've started off, with writing few simple functions, such as format, add, subtract, duration - just to make the usage of Date a little simpler. But that list started to expand slowly and realistically... has been solved elsewhere. So instead of wasting time, I took a smaller steps and the time, and opted in for date-fns. Fell in love on the way.

As part of this, while manually having to change the usage of moment, my eyes were hurt by some linting highlights, so I've fixed them on the way.

How to review

• Sanity check
• Code review
• Have a look around a running instance (specifically around metrics please)

🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️🚨

[kr8n3r]

service metrics filter range on first view (last 24 hours):

• end date should be today, but it's today - 1
• Each point on a graph is aggregated over 300 seconds of data, whereas on prod we convert that to 5 minutes (minor thing i reckon)
• not sure if I can trust the graph start point (issue with stub data?)

[paroxp]

end date should be today, but it's today - 1

I believe this is now fixed :)

Each point on a graph is aggregated over 300 seconds of data, whereas on prod we convert that to 5 minutes (minor thing i reckon)

Actually that's a good spot. If this was to be 10000000s it would still not normalise... I've implemented a hack to take care of it.

not sure if I can trust the graph start point (issue with stub data?)

I would hope so 😬

we now say 1 week, previously we said 7 days. i'm fine with that

I think I'm cool with that too 🤔

[kr8n3r]

I'd like to test generated graphs and CSV download where data is more reliable. Can we deploy to somewhere?

graphs look look on dev01, metrics range times are UTC (BST -1), csv timestamp looks ok

[kr8n3r]

massive piece of work 💯