Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to get the acceptance tests running faster in environments wit… #193

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

corlettb
Copy link
Contributor

@corlettb corlettb commented Nov 17, 2023

What

Tweaks to get the acceptance tests running faster in environments with lots of data:

  • Reduced the time window we are pulling from the billing api
  • Only work out the orgGUIDWithEvents once rather than for every test.

Plus gofmt.

Fix timing issue in auth unit test

Why

Acceptance tests in production are failing due to them taking over 20 mins to run. The oauth token expires after 20 mins.

The tests are currently pulling down 150mb+ of data from the billing api with each successful call to billable-events.

How to review

Look at the changes


🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️🚨

Copy link
Contributor

@dark5un dark5un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@corlettb corlettb merged commit b1a5233 into main Dec 4, 2023
2 checks passed
@corlettb corlettb deleted the 186492678-acceptance-tests-performance branch December 4, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants